Discussion:
Some typos in draft 2
Thomas Huth
2014-04-28 05:55:08 UTC
Permalink
Hi,

not sure whether they've been discovered yet, but here are some small
typos in the virtio v1.0 draft 2:

- Chapter 5.1.6 Device Operation:
"In each case, the packet itself is preceeded by a header"
==> s/preceeded/preceded/

- In the footnote on page 58 (chapter 5.1.6.4.3):
"Since there are no guarentees, it can use a hash filter ..."
==> s/guarentees/guarantees/

- Chapter 5.2.7.1 Legacy Interface: Device Operation (page 65):
"... this request acts as a barrier and that all preceeding requests
SHOULD be complete ..."
==> s/preceeding/preceding/

Thomas


This publicly archived list offers a means to provide input to the

OASIS Virtual I/O Device (VIRTIO) TC.



In order to verify user consent to the Feedback License terms and

to minimize spam in the list archive, subscription is required

before posting.



Subscribe: virtio-comment-***@lists.oasis-open.org

Unsubscribe: virtio-comment-***@lists.oasis-open.org

List help: virtio-comment-***@lists.oasis-open.org

List archive: https://lists.oasis-open.org/archives/virtio-comment/

Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf

List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists

Committee: https://www.oasis-open.org/committees/virtio/

Join OASIS: https://www.oasis-open.org/join/
Rusty Russell
2014-04-29 02:35:16 UTC
Permalink
Thanks Thomas!

I've assigned this VIRTIO-99 in the bug tracker:

https://tools.oasis-open.org/issues/browse/VIRTIO-99

Cheers,
Rusty.
Post by Thomas Huth
Hi,
not sure whether they've been discovered yet, but here are some small
"In each case, the packet itself is preceeded by a header"
==> s/preceeded/preceded/
"Since there are no guarentees, it can use a hash filter ..."
==> s/guarentees/guarantees/
"... this request acts as a barrier and that all preceeding requests
SHOULD be complete ..."
==> s/preceeding/preceding/
Thomas
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
This publicly archived list offers a means to provide input to the

OASIS Virtual I/O Device (VIRTIO) TC.



In order to verify user consent to the Feedback License terms and

to minimize spam in the list archive, subscription is required

before posting.



Subscribe: virtio-comment-***@lists.oasis-open.org

Unsubscribe: virtio-comment-***@lists.oasis-open.org

List help: virtio-comment-***@lists.oasis-open.org

List archive: https://lists.oasis-open.org/archives/virtio-comment/

Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf

List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists

Committee: https://www.oasis-open.org/committees/virtio/

Join OASIS: https://www.oasis-open.org/join/
Rusty Russell
2014-04-29 04:25:37 UTC
Permalink
And here's the proposed patch:

commit 456e4feb8165dc5b1c9a739d9ad0cf4ac9145d79
Author: Rusty Russell <***@au1.ibm.com>
Date: Tue Apr 29 13:54:32 2014 +0930

VIRTIO-99: Typo fixes.

Reported-by: Thomas Huth <***@linux.vnet.ibm.com>
Signed-off-by: Rusty Russell <***@au1.ibm.com>

diff --git a/content.tex b/content.tex
index 58c3ebc..b5a3ce0 100644
--- a/content.tex
+++ b/content.tex
@@ -3041,7 +3041,7 @@ everything else.
Packets are transmitted by placing them in the
transmitq1\ldots transmitqN, and buffers for incoming packets are
placed in the receiveq1\ldots receiveqN. In each case, the packet
-itself is preceeded by a header:
+itself is preceded by a header:

\begin{lstlisting}
struct virtio_net_hdr {
@@ -3328,7 +3328,7 @@ struct virtio_net_ctrl_mac {
\end{lstlisting}

The device can filter incoming packets by any number of destination
-MAC addresses.\footnote{Since there are no guarentees, it can use a hash filter or
+MAC addresses.\footnote{Since there are no guarantees, it can use a hash filter or
silently switch to allmulti or promiscuous mode if it is given too
many addresses.
} This table is set using the class
@@ -3783,7 +3783,7 @@ a driver MUST treat it as a VIRTIO_BLK_T_FLUSH command.

If the device has VIRTIO_BLK_F_BARRIER
feature the high bit (VIRTIO_BLK_T_BARRIER) indicates that this
-request acts as a barrier and that all preceeding requests SHOULD be
+request acts as a barrier and that all preceding requests SHOULD be
complete before this one, and all following requests SHOULD NOT be
started until this is complete.



This publicly archived list offers a means to provide input to the

OASIS Virtual I/O Device (VIRTIO) TC.



In order to verify user consent to the Feedback License terms and

to minimize spam in the list archive, subscription is required

before posting.



Subscribe: virtio-comment-***@lists.oasis-open.org

Unsubscribe: virtio-comment-***@lists.oasis-open.org

List help: virtio-comment-***@lists.oasis-open.org

List archive: https://lists.oasis-open.org/archives/virtio-comment/

Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf

List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists

Committee: https://www.oasis-open.org/committees/virtio/

Join OASIS: https://www.oasis-open.org/join/

Loading...